[PATCH] D80233: [mlir][rocdl] Exposing buffer load/store intrinsic

Zhuoran Yin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 08:10:56 PDT 2020


jerryyin marked 2 inline comments as done.
jerryyin added inline comments.


================
Comment at: mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp:37
+
+static void printROCDLIntrinsicOp(OpAsmPrinter &p, Operation *op) {
+  p << op->getName() << " " << op->getOperands();
----------------
whchung wrote:
> @jerryyin It seems this printing function is only used by `ROCDL_MubufLoadOp`, but no one else.
I have inlined it in the tablegen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80233/new/

https://reviews.llvm.org/D80233





More information about the llvm-commits mailing list