[PATCH] D78922: [CostModel] Remove getExtCost

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 07:35:29 PDT 2020


dmgreen added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:717
+
+      if (getTLI()->isExtFree(I))
+        return 0;
----------------
I don't believe this will be correct from the vectorizer. It can pass a context instruction that has different types to the final IR due to it truncating at the same time it vectorizes. It is generally unsound to rely on I being accurate.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78922/new/

https://reviews.llvm.org/D78922





More information about the llvm-commits mailing list