[PATCH] D80270: [mlir][spirv] Adapt subview legalization to the updated op semantics.

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache accepted this revision.
nicolasvasilache added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Conversion/StandardToSPIRV/LegalizeStandardForSPIRV.cpp:74
+  for (unsigned idx = 0; idx < rank; ++idx) {
+    if (subViewOp.isDynamicOffset(idx)) {
+      opOffsets.push_back(subViewOp.getDynamicOffset(idx));
----------------
since this pattern is likely to repeat itself more and more, how about adding `getOrCreateOffset/Size/StrideValue` to the core op?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80270/new/

https://reviews.llvm.org/D80270