[PATCH] D80099: [llvm-objcopy][MachO] Add support for removing Swift symbols

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap marked an inline comment as done.
alexshap added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:608
+  if (Config.StripSwiftSymbols)
+    return createStringError(llvm::errc::invalid_argument,
+                             "option not supported by llvm-objcopy for ELF");
----------------
jhenderson wrote:
> I think there's a `std::errc::not_supported` you could use here.
I think it's important to be consistent in what we return in such cases, 
I've looked at the COFF / MachO versions - they both return invalid_argument.
So my point is that if we want to change it then it should be discussed and done separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80099/new/

https://reviews.llvm.org/D80099