[PATCH] D80190: [yaml2obj] - Implement the "Offset" property for the Fill Chunk.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 02:40:15 PDT 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/custom-fill.yaml:309
+
+# OFFSET-MIN:      There are 5 section headers, starting at offset 0x68:
+# OFFSET-MIN:      Section Headers:
----------------
jhenderson wrote:
> I'm not sure we really need to check the section header table offset, as the position of .bar is sufficient to show the fill impacts the offset calculations.
Probably you're right. Not sure why I've added this line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80190/new/

https://reviews.llvm.org/D80190





More information about the llvm-commits mailing list