[PATCH] D80072: Make Value::getPointerAlignment() return an Align, not a MaybeAlign.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 23:02:41 PDT 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

I still think this is the right thing to do and the changes are fine. LGTM. (Let's wait again a little while or until we get another person to look at this.)

Nit: Commit message should be updated. Maybe refer to the clang patch and mention the loads.cpp bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80072/new/

https://reviews.llvm.org/D80072





More information about the llvm-commits mailing list