[PATCH] D80231: [llvm] [CodeGen] [X86] Fix issues with v4i1 instruction selection

Aart Bik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 22:30:23 PDT 2020


aartbik added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:39635
+          MVT::INVALID_SIMPLE_VALUE_TYPE) {
     MVT IntVT = MVT::getIntegerVT(VT.getVectorNumElements());
     bool LHSIsConst = ISD::isBuildVectorOfConstantSDNodes(LHS.getNode());
----------------
craig.topper wrote:
> Can we just change this to EVT instead?
Yes, that works too. Thanks! I changed it, and also added a regression test for the previous crash, just to make sure this keeps working.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80231/new/

https://reviews.llvm.org/D80231





More information about the llvm-commits mailing list