[PATCH] D80203: [ObjectYAML][DWARF] Add DWARF entry in ELFYAML.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing marked an inline comment as done.
Higuoxing added inline comments.


================
Comment at: llvm/lib/ObjectYAML/DWARFYAML.cpp:36
+    SecNames.push_back("debug_ranges");
+  if (PubNames.Entries.size() != 0)
+    SecNames.push_back("debug_pubnames");
----------------
grimar wrote:
> Why this is `!DWARF.PubNames.Entries` and not `!DWARF.PubNames`?
> (The same question for things around).
Because `Data` possesses `PubNames` directly, rather than `Optional<PubNames>`.

```
struct PubNames {
  ...
  std::vector<PubEntry> Entries;
};

struct Data {
  PubSection PubNames;
};
```

Can I fix it in the next patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80203/new/

https://reviews.llvm.org/D80203