[PATCH] D80203: [ObjectYAML][DWARF] Add DWARF entry in ELFYAML.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 21:58:14 PDT 2020


Higuoxing marked an inline comment as done.
Higuoxing added inline comments.


================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:396
     initStrtabSectionHeader(Header, SecName, DotDynstr, CBA, YAMLSec);
+  else if (SecName.startswith(".debug_") && !YAMLSec)
+    reportError(SecName + " section is not implemented");
----------------
grimar wrote:
> Why do you need `&& !YAMLSec`?
We have some DebugInfo test cases using yaml2obj to generate debug sections via raw content.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80203/new/

https://reviews.llvm.org/D80203





More information about the llvm-commits mailing list