[PATCH] D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link()

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 16:00:17 PDT 2020


aganea added a comment.

In D70378#2045190 <https://reviews.llvm.org/D70378#2045190>, @amccarth wrote:

> I read back through some of the history, but I still don't feel like I have all the context.  That said, this change looks simple and straightforward to me.
>
> Would it be feasible and useful to create a test that links two trivial programs with a single instantiation of the lld process?  It seems like it would detect regressions and catch any introduction of a new global that needs to be reset.


That is great suggestion! I will see what I can do. Maybe something along the lines of `LLVM_ENABLE_ASSERTIONS` + `LLVM_ENABLE_EXPENSIVE_CHECKS` + run all LLD tests while calling `link()` three times in a row?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70378/new/

https://reviews.llvm.org/D70378





More information about the llvm-commits mailing list