[PATCH] D79625: [PowerPC] Extend .reloc directive on PowerPC

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 15:27:50 PDT 2020


NeHuang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp:50
     return Value & 0x3ffffffff;
+  case PPC::fixup_ppc_linker_opt:
+    return Value;
----------------
nit: Can we move this to line 36 as we already have a case return Value.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp:166
       return Kind >= FirstLiteralRelocationKind;
+    case FK_NONE:
+    case PPC::fixup_ppc_linker_opt:
----------------
Why do we need to add `case FK_NONE`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79625/new/

https://reviews.llvm.org/D79625





More information about the llvm-commits mailing list