[PATCH] D80103: [cmake][NFC] Check for incorrect usage of LLVM components in LINK_LIBS

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer marked an inline comment as done.
stephenneuendorffer added inline comments.


================
Comment at: mlir/cmake/modules/AddMLIR.cmake:113
+  # LINK_COMPONENTS is necessary to allow libLLVM.so to be properly
+  # substituted for individual library dependencies if LLVM_LINK_LLVM_DYLIB
+  get_property(llvm_component_libs GLOBAL PROPERTY LLVM_COMPONENT_LIBS)
----------------
mehdi_amini wrote:
> Is the kind of things like LINK_COMPONENTS documented somewhere? I always end-up having to reverse engineer all this from the implementation, but I'll forget about the detail by the next time I have to do something significant there
https://mlir.llvm.org/docs/Tutorials/CreatingADialect/#cmake-best-practices-1
https://llvm.org/docs/Projects.html

The LLVM global documentation is woefully limited, but I haven't gotten motivated to wade into it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80103/new/

https://reviews.llvm.org/D80103