[PATCH] D80164: [WebAssembly] Fix bug in custom shuffle combine

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 13:44:46 PDT 2020


aheejin added a comment.

In D80164#2043610 <https://reviews.llvm.org/D80164#2043610>, @aheejin wrote:

> LGTM.
>
> A separate question: In wasm_simd128.h <https://github.com/llvm/llvm-project/blob/master/clang/lib/Headers/wasm_simd128.h>, why are the type for all return values `v128_t`? If we don't cast return types to `v128_t` <https://github.com/llvm/llvm-project/blob/56079e1de1129837aa7569d8b3bb5e50afc0f1ea/clang/lib/Headers/wasm_simd128.h#L315> and return `__f32x4` as is, are bitcasts still gonna be generated?


Ping


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80164/new/

https://reviews.llvm.org/D80164





More information about the llvm-commits mailing list