[PATCH] D79751: [PGO] Add memcmp/bcmp size value profiling.

[Hiroshi Yamauchi via Phabricator via llvm-commits]

yamauchi added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp:98
 
+static cl::opt<bool>
+    MemOPOptMemcmpBcmp("pgo-memop-optimize-memcmp-bcmp", cl::init(true),
----------------
davidxl wrote:
> make it default to false for the first patch?
Done.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp:204
+  }
+  const char *getShortName(TargetLibraryInfo &TLI) {
+    if (auto MI = asMI())
----------------
davidxl wrote:
> why 'getShortName' ?  There does not seem be a need for 'long name'.
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79751/new/

https://reviews.llvm.org/D79751