[PATCH] D62884: [lld] Explicitly ignore comdat groups when parsing LTO object

Christy Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 12:03:10 PDT 2020


christylee added a comment.

We are trying to migrate from gold to lld, and we found that when building with thinlto, lld does not de-duplicate `.debug_types`.  De-duplication is successful with monolithic lto.  Repro: clang `-flto=thin -fdebug-types-section -fuse-ld=lld -Wl,-plugin-opt=-generate-type-units`

If we set `ignoreComdats=false` for lto builds, then the de-duplication is successful again.  Is the assumption "any symbols defined in the LTO object are by definition the ones we want in the final output" only true for monolithic lto?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62884/new/

https://reviews.llvm.org/D62884





More information about the llvm-commits mailing list