[PATCH] D79951: [ProfileSummary] Add the PartialProfileRatio field in ProfileSummary metadata.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 09:49:13 PDT 2020


davidxl added inline comments.


================
Comment at: llvm/lib/IR/ProfileSummary.cpp:77
 // IsPartialProfile is an optional field and \p AddPartialField will decide
 // whether to add a field for it.
+Metadata *ProfileSummary::getMD(LLVMContext &Context, bool AddPartialField,
----------------
Document the new parameter in the comment.


================
Comment at: llvm/lib/IR/ProfileSummary.cpp:195
 
-  int i = 0;
-  auto &FormatMD = Tuple->getOperand(i++);
+  unsigned I = 0;
+  auto &FormatMD = Tuple->getOperand(I++);
----------------
can you commit the style changes as NFC first?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79951/new/

https://reviews.llvm.org/D79951





More information about the llvm-commits mailing list