[PATCH] D79984: [yaml2obj] - Add a technical suffix for each unnamed chunk.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:415
 
 constexpr StringRef SuffixStart = " (";
 constexpr char SuffixEnd = ')';
----------------
I think the code can be simplified if you change here to `constexpr char SuffixStart = '('`


================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:420
                                               const Twine &Msg) {
+  // Do not add a space when a Name is empty.
+  if (Name.empty())
----------------
`s/a //`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79984/new/

https://reviews.llvm.org/D79984