[PATCH] D80167: [mlir][gpu] Refactor ConvertGpuLaunchFuncToCudaCalls pass.

Wen-Heng (Jack) Chung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 08:41:35 PDT 2020


whchung added a comment.

In D80167#2043575 <https://reviews.llvm.org/D80167#2043575>, @herhut wrote:

> As an alternative, we could stick with fixed names, replace the `mcu` prefix by something neutral and then for AMD use case we link a different helper library in the tests. WDYT?


@herhut I revised the patch so:

- runtime wrapper APIs have more platform-neutral names.
- GPU binary blobs still carry platform-specific attributes, and could be specified as a PassOption. If none specified, default would still be `nvvm.cubin`.
- Also it seems `nvvm.cubingetter` is no longer used so I removed it from this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80167/new/

https://reviews.llvm.org/D80167





More information about the llvm-commits mailing list