[PATCH] D80206: [IR] Clean up dead instructions after simplifying a conditional branch

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 07:34:11 PDT 2020


jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:135
+      RecursivelyDeleteTriviallyDeadInstructionsPermissive(MaybeDeadHandles,
+                                                           TLI);
 
----------------
It seems unfortunate that we need to copy the vector. Do we believe there is another use case for `MaybeDeadInstrs` so we want it to take a `Instruction` vector?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80206/new/

https://reviews.llvm.org/D80206





More information about the llvm-commits mailing list