[PATCH] D78206: [Target][ARM] Make Low Overhead Loops coexist with VPT blocks

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 07:00:34 PDT 2020


samparker added a comment.

Is there a test for the case for something like this?

  VPTTT
  VLDRT
  VCTPT
  VSTRT

I just want to guarantee that we reject this.



================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:398
       continue;
     if (!Block.HasNonUniformPredicate() || !isVCTP(Block.getDivergent()->MI)) {
+      PredicatedMI *Divergent = Block.getDivergent();
----------------
Looking at this again, I guess the logic should be if (Block.HasNonUniformPredicate() && !isVCTP(...)) because then we won't try to dereference a nullptr.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78206/new/

https://reviews.llvm.org/D78206





More information about the llvm-commits mailing list