[PATCH] D80204: [llvm-readobj] - Do not skip building of the GNU hash table histogram.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 05:54:59 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar updated this revision to Diff 264870.
grimar added a comment.

- Fix legacy comments.


When the `--elf-hash-histogram` is used, the code first tries to build
a histogram for the .hash table and then for the .gnu.hash table.

The problem is that dumper might return early when unable or do not need to
build a histogram for the .hash.

This patch reorders the code slightly to fix the issue and adds a test case.


https://reviews.llvm.org/D80204

Files:
  llvm/test/tools/llvm-readobj/ELF/hash-histogram.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80204.264870.patch
Type: text/x-patch
Size: 5835 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200519/d333cd58/attachment.bin>


More information about the llvm-commits mailing list