[PATCH] D79863: [DebugInfo] Refactor SalvageDebugInfo and SalvageDebugInfoForDbgValues

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:3361
+    salvageDebugInfoForDbgValues(*I, DbgUsers);
+    for (auto &DIIClone : DIIClones) {
+      DIIClone->insertBefore(&*InsertPos);
----------------
Sorry I didn't pick this up with my other comments. I think this should be `auto *DIIClone` (or `DbgVariableIntrinsic *DIIClone`) because `DIIClones` is `SmallVector<DbgVariableIntrinsic *, 2>`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79863/new/

https://reviews.llvm.org/D79863