[PATCH] D80123: [yaml2obj][obj2yaml] - Stop using square brackets for unique suffixes.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Just a couple of small test suggestions for documentation purposes.



================
Comment at: llvm/test/tools/yaml2obj/ELF/duplicate-section-names.yaml:35-36
+    Type: SHT_PROGBITS
+  - Name: '.foo2 ()'
+    Type: SHT_PROGBITS
 
----------------
If I understand it correctly, `'.foo2 (asbdjasbdjasbd)'` is also a valid unique suffix. Perhaps worth showing that arbitrary contents are allowed in there?


================
Comment at: llvm/test/tools/yaml2obj/ELF/duplicate-symbol-names.yaml:18
   - Name: localfoo
-  - Name: 'localfoo [1]'
+  - Name: 'localfoo (1)'
 
----------------
Same comment as above. Perhaps worth showing that the contents of the '()' can be arbitrary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80123/new/

https://reviews.llvm.org/D80123