[PATCH] D71261: [ThinLTO] upgrade IR symtab in parallel ahead of time

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 23:19:10 PDT 2020


ychen added a comment.

In D71261#2038881 <https://reviews.llvm.org/D71261#2038881>, @tejohnson wrote:

> It would be good to add equivalent support to gold-plugin.cpp as well so that those remain in sync on functionality.


It seems that the gold plugin API does not work well with the pre-upgrade this patch is proposing. Without pre-upgrade, the upgrade happens during `InputFile::create` in `claim_file_hook`. Pre-upgrade needs to happen before `claim_file_hook` where something like `vector<Input_path>` is available. The plugin API does not seem to have this hook. Not quite sure how to proceed with this restriction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71261/new/

https://reviews.llvm.org/D71261





More information about the llvm-commits mailing list