[PATCH] D80173: Give microsoftDemangle() an outparam for how many input bytes were consumed.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 17:22:19 PDT 2020


thakis created this revision.
thakis added a reviewer: hans.
Herald added subscribers: rupprecht, MaskRay, hiraditya.
Herald added a reviewer: jhenderson.
Herald added a reviewer: MaskRay.
Herald added a project: LLVM.

Demangling Itanium symbols either consumes the whole input or fails,
but Microsoft symbols can be successfully demangled with just some
of the input.

Add an outparam that enables clients to know how much of the input was
consumed, andn use this flag to give llvm-undname an opt-in warning
on partially consumed symbols.


https://reviews.llvm.org/D80173

Files:
  lldb/source/Core/Mangled.cpp
  llvm/include/llvm/Demangle/Demangle.h
  llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
  llvm/lib/Demangle/Demangle.cpp
  llvm/lib/Demangle/MicrosoftDemangle.cpp
  llvm/test/Demangle/warn-trailing.test
  llvm/tools/llvm-microsoft-demangle-fuzzer/llvm-microsoft-demangle-fuzzer.cpp
  llvm/tools/llvm-objdump/COFFDump.cpp
  llvm/tools/llvm-undname/llvm-undname.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80173.264757.patch
Type: text/x-patch
Size: 7485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200519/143f5727/attachment.bin>


More information about the llvm-commits mailing list