[PATCH] D78459: [AVR] Don't adjust for instruction size

Mon May 18 15:12:25 PDT 2020

aykevl added a comment.

Glad to see you're working on AVR again!

In D78459#2040419 <https://reviews.llvm.org/D78459#2040419>, @dylanmckay wrote:

> Before merging this, I want to run it under the emulated AVR integration tests I've been working on, just to build 100% confidence that it does what it says on the tin.

That sounds great! As you can see with the patches I submitted, I hit a number of miscompilations when I tried to compile and run the compiler-rt tests. I'm sure there are more. Are you planning on adding these integration tests to the LLVM buildbot or something more manual?

Eventually, we might be able to run the GCC torture test suite to find the remaining bugs. It is a whole lot easier to find a bug in a small contained test than it is to find a bug in a larger application that only breaks on AVR. Even known-working and known-broken tests would be useful, to track progress (and catch regressions soon after they've been introduced).

Anyway, looking forward to these tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78459/new/

https://reviews.llvm.org/D78459