[PATCH] D80107: [SVE] Remove IITDescriptor::ScalableVecArgument

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 14:06:16 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.h:110
 
+    struct VectorWidth {
+      unsigned NumElts : 30;
----------------
Can you just use ElementCount here, instead of defining your own struct?

If you do think it's necessary to pack this struct, please ensure that the struct can hold all the values ElementCount can hold.  I don't want the possibility of new mysterious failures due to overflow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80107/new/

https://reviews.llvm.org/D80107





More information about the llvm-commits mailing list