[PATCH] D78208: [DebugInfo] Report the format of the DWARF64 sections.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:302
   OS << format("%08" PRIx64, Offset)
      << format(" %0*" PRIx64, IsDWARF64 ? 16 : 8, Length)
      << format(" %0*" PRIx64, IsDWARF64 && !IsEH ? 16 : 8,
----------------
dblaikie wrote:
> Looks like this format already provides some precedent for using 16 hex digit alignment for DWARF64 and 8 for DWARF32. It seems like you've updated /some/ places to do that but not all? (eg: debug_pubnames still seems to use an 8 hex digit rendering of the length )
> 
> & yeah, as Jared mentioned - I don't think the text format of the dumper is a place to worry too much about format changing, etc. But I don't feel /super/ strongly about only rendering this data via the length of the length field, versus being more explicit in some way, but I'd like the length rendering to be consistent across the different length fields/sections/etc.
I can speak from experience that I received a surprising of reports about various broken perl scripts whenever we changed the output format of dwarfdump, so it's reasonable to be mindful. But this change is additive and carries important information, so let's do it!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78208/new/

https://reviews.llvm.org/D78208