[llvm] 691980e - [llvm][NFC] Fixed non-compliant style in InlineAdvisor.h

Mircea Trofin via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 10:28:11 PDT 2020


Author: Mircea Trofin
Date: 2020-05-18T10:26:45-07:00
New Revision: 691980ebb47127c611be6e85f27e1778d5d213d8

URL: https://github.com/llvm/llvm-project/commit/691980ebb47127c611be6e85f27e1778d5d213d8
DIFF: https://github.com/llvm/llvm-project/commit/691980ebb47127c611be6e85f27e1778d5d213d8.diff

LOG: [llvm][NFC] Fixed non-compliant style in InlineAdvisor.h

Changed OnPass{Entry|Exit} -> onPass{Entry|Exit}

Also fixed a small typo in a comment.

Added: 
    

Modified: 
    llvm/include/llvm/Analysis/InlineAdvisor.h
    llvm/lib/Transforms/IPO/Inliner.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Analysis/InlineAdvisor.h b/llvm/include/llvm/Analysis/InlineAdvisor.h
index 115bca1d3219..118fd236bee4 100644
--- a/llvm/include/llvm/Analysis/InlineAdvisor.h
+++ b/llvm/include/llvm/Analysis/InlineAdvisor.h
@@ -123,12 +123,12 @@ class InlineAdvisor {
   /// This must be called when the Inliner pass is entered, to allow the
   /// InlineAdvisor update internal state, as result of function passes run
   /// between Inliner pass runs (for the same module).
-  virtual void OnPassEntry() {}
+  virtual void onPassEntry() {}
 
   /// This must be called when the Inliner pass is exited, as function passes
   /// may be run subsequently. This allows an implementation of InlineAdvisor
   /// to prepare for a partial update.
-  virtual void OnPassExit() {}
+  virtual void onPassExit() {}
 
 protected:
   InlineAdvisor() = default;
@@ -163,7 +163,7 @@ class DefaultInlineAdvisor : public InlineAdvisor {
   std::unique_ptr<InlineAdvice>
   getAdvice(CallBase &CB, FunctionAnalysisManager &FAM) override;
 
-  void OnPassExit() override { freeDeletedFunctions(); }
+  void onPassExit() override { freeDeletedFunctions(); }
   InlineParams Params;
 };
 

diff  --git a/llvm/lib/Transforms/IPO/Inliner.cpp b/llvm/lib/Transforms/IPO/Inliner.cpp
index 770ca2ea9130..862385d04481 100644
--- a/llvm/lib/Transforms/IPO/Inliner.cpp
+++ b/llvm/lib/Transforms/IPO/Inliner.cpp
@@ -696,9 +696,9 @@ PreservedAnalyses InlinerPass::run(LazyCallGraph::SCC &InitialC,
   ProfileSummaryInfo *PSI = MAMProxy.getCachedResult<ProfileSummaryAnalysis>(M);
 
   InlineAdvisor &Advisor = getAdvisor(MAMProxy, M);
-  Advisor.OnPassEntry();
+  Advisor.onPassEntry();
 
-  auto AdvisorOnExit = make_scope_exit([&] { Advisor.OnPassExit(); });
+  auto AdvisorOnExit = make_scope_exit([&] { Advisor.onPassExit(); });
 
   if (!ImportedFunctionsStats &&
       InlinerFunctionImportStats != InlinerFunctionImportStatsOpts::No) {
@@ -808,7 +808,7 @@ PreservedAnalyses InlinerPass::run(LazyCallGraph::SCC &InitialC,
       return FAM.getResult<AssumptionAnalysis>(F);
     };
 
-    // Now process as many calls as we have within this caller in the sequnece.
+    // Now process as many calls as we have within this caller in the sequence.
     // We bail out as soon as the caller has to change so we can update the
     // call graph and prepare the context of that new caller.
     bool DidInline = false;


        


More information about the llvm-commits mailing list