[PATCH] D80138: [mlir] ensureRegionTerminator: take OpBuilder

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 10:13:37 PDT 2020


nicolasvasilache added a comment.

After seeing the stack of CL I am wondering whether RewritePatterns should only operate on Wrapper classes around Region, Block and Operation that would inherit privately.

Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80138/new/

https://reviews.llvm.org/D80138





More information about the llvm-commits mailing list