[PATCH] D79100: [LV][TTI] Emit new IR intrinsic llvm.get.active.mask

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 08:34:37 PDT 2020


SjoerdMeijer added a comment.

In D79100#2041646 <https://reviews.llvm.org/D79100#2041646>, @samparker wrote:

> I was expecting the intrinsic to be performing the icmp because it feels as though if a target wants an intrinsic like this, that it would want it to do //something//?


That was my initial though too, so started drafting an intrinsic that would take the induction step, backedge taken count, the comparison operator, thus replacing the icmp, and feeding its result into the masked load/stores.
This however, turned out to be a massively invasive change because of the different places where the induction variable is widened which creates the induction step and icmp, and where the masking happens. This change is very minimal, makes explicit exactly the same information, and thus had my preference.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79100/new/

https://reviews.llvm.org/D79100





More information about the llvm-commits mailing list