[PATCH] D80114: [VPlan] Add & use VPValue operands for VPReplicateRecipe (NFC).

Gil Rapaport via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 08:01:57 PDT 2020


gilr accepted this revision.
gilr added a comment.
This revision is now accepted and ready to land.

LGTM with a nit. Thanks!



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:445
+  /// inclusive. Uses the VPValue operands from \p Operands instead of \p
+  /// Instr's operands directly.
+  void scalarizeInstruction(Instruction *Instr, VPUser &Operands,
----------------
I'd omit "directly" to avoid implying that Operands necessarily wrap Instr's operands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80114/new/

https://reviews.llvm.org/D80114





More information about the llvm-commits mailing list