[PATCH] D79671: [MsgPack] MsgPackDocument::readFromBlob now merges

Tim Renouf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 04:15:15 PDT 2020


tpr marked 3 inline comments as done.
tpr added a comment.

With the nil/empty change, there is a change in behavior in that doing a map lookup "map[key]" with a key not previously in the map creates a new map entry that is empty rather than nil. That is more correct, but I have just discovered some code in LLPC relying on the old behavior. I can fix the LLPC code, but is the change in behavior going to cause any HSA problems?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79671/new/

https://reviews.llvm.org/D79671





More information about the llvm-commits mailing list