[PATCH] D80012: [CostModel] Unify Intrinsic Costs.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 00:29:43 PDT 2020


samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:563
                                       TTI::TargetCostKind CostKind) {
+  if (ICA.getID() == Intrinsic::fabs)
+    return 0;
----------------
arsenm wrote:
> Previously this would have been reported from TLI.isFAbsFree, but I don't see that check getting dropped here?
I don't recall seeing a check like that... but it makes sense. Having the base implementation call it should work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80012/new/

https://reviews.llvm.org/D80012





More information about the llvm-commits mailing list