[PATCH] D77523: Add CanonicalizeFreezeInLoops pass

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune marked 9 inline comments as done.
aqjune added a comment.

Thank you! I'll wait 2 days and land this on Wednesday.



================
Comment at: llvm/lib/Passes/PassBuilder.cpp:182
 #include "llvm/Transforms/Utils/CanonicalizeAliases.h"
+#include "llvm/Transforms/Utils/CanonicalizeFreezeInLoops.h"
 #include "llvm/Transforms/Utils/EntryExitInstrumenter.h"
----------------
fhahn wrote:
> nit: unused?
This seems to be needed by PassRegistry.def .


================
Comment at: llvm/test/Transforms/CanonicalizeFreezeInLoops/onephi.ll:4
+; A set of tests that have one phi node
+target triple = "aarch64-unknown-linux-gnu"
+declare void @call(i32)
----------------
fhahn wrote:
> does this require an AArch64 triple? If so, you have to add something like `REQUIRES: aarch64-registered-target` I think, otherwise it might if LLVM is built without AARch64 backend.
aarch64 wasn't needed. removed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77523/new/

https://reviews.llvm.org/D77523