[PATCH] D80075: [MLIR][cmake][NFC] Update linkage checker for mlir-opt

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer created this revision.
Herald added subscribers: llvm-commits, jurahul, Kayjukh, frgossen, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini, Charusso, mgorny.
Herald added a project: LLVM.
stephenneuendorffer added a child revision: D80076: [MLIR] Fix linkage for libMLIR.so.

New CMakeLists.txt for MLIRStandardOpsTransforms was incorrect, but wasn't
caught by the check.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80075

Files:
  mlir/cmake/modules/AddMLIR.cmake
  mlir/tools/mlir-opt/CMakeLists.txt


Index: mlir/tools/mlir-opt/CMakeLists.txt
===================================================================
--- mlir/tools/mlir-opt/CMakeLists.txt
+++ mlir/tools/mlir-opt/CMakeLists.txt
@@ -52,4 +52,4 @@
 target_link_libraries(mlir-opt PRIVATE ${LIBS})
 llvm_update_compile_flags(mlir-opt)
 
-mlir_check_link_libraries(mlir-opt)
+mlir_check_all_link_libraries(mlir-opt)
Index: mlir/cmake/modules/AddMLIR.cmake
===================================================================
--- mlir/cmake/modules/AddMLIR.cmake
+++ mlir/cmake/modules/AddMLIR.cmake
@@ -179,7 +179,7 @@
           # same symbol might be loaded from 2 separate libraries.  This
           # often comes from referring to an LLVM library target
           # explicitly in target_link_libraries()
-          message("WARNING: ${l} links LLVM and ${lib}!")
+          message("WARNING: ${name} links LLVM and ${lib}!")
         endif()
       endif()
     endforeach()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80075.264475.patch
Type: text/x-patch
Size: 936 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200517/bae8ec63/attachment.bin>