[PATCH] D80072: Make Value::getPointerAlignment() return an Align, not a MaybeAlign.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 16 18:33:27 PDT 2020


efriedma created this revision.
efriedma added reviewers: apilipenko, hfinkel, jdoerfert.
Herald added subscribers: kuter, hiraditya.
Herald added a reviewer: sstefan1.
Herald added a project: LLVM.

If we don't know anything about the alignment of a pointer, Align(1) is still correct: all pointers are at least 1-byte aligned.

The changes to Loads.cpp are messy; I'm not sure what the original intent was.  It looks like the logic in question originates from D9791 <https://reviews.llvm.org/D9791>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80072

Files:
  llvm/include/llvm/IR/Value.h
  llvm/lib/Analysis/Loads.cpp
  llvm/lib/Analysis/ValueTracking.cpp
  llvm/lib/CodeGen/ExpandMemCmp.cpp
  llvm/lib/IR/ConstantFold.cpp
  llvm/lib/IR/Value.cpp
  llvm/lib/Target/AArch64/AArch64InstrInfo.td
  llvm/lib/Transforms/IPO/AttributorAttributes.cpp
  llvm/unittests/IR/FunctionTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80072.264463.patch
Type: text/x-patch
Size: 13455 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200517/e03963df/attachment.bin>


More information about the llvm-commits mailing list