[PATCH] D80058: [LegalizeVectorTypes] Create correct memoperands in SplitVecRes_INSERT_SUBVECTOR.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 16 13:45:34 PDT 2020


efriedma added a comment.

getUnknownStack() doesn't actually do anything at the moment except set the correct address-space.  But I guess that's still an improvement.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1163
   SDValue Store =
-      DAG.getStore(DAG.getEntryNode(), dl, Vec, StackPtr, MachinePointerInfo());
+      DAG.getStore(DAG.getEntryNode(), dl, Vec, StackPtr, PtrInfo);
 
----------------
While you're here, please pass the alignment consistently to all the load/store operations where it applies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80058/new/

https://reviews.llvm.org/D80058





More information about the llvm-commits mailing list