[PATCH] D79959: [SampleFDO] Add use-sample-profile function attribute

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 15 22:36:59 PDT 2020


wenlei added a comment.

If we make it a function attribute, do we need to reject pre-LTO (CGSCC)  inlining between function with different attribute value? If we always expect this attribute to be consistent among functions from the same module, this won't be a problem. However having it as a function attribute does offer function level flexibility (e.g. if this is exposed through `__attribute(..)__`), and we may want to account for it..


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79959/new/

https://reviews.llvm.org/D79959





More information about the llvm-commits mailing list