[PATCH] D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs added a comment.

In D79963#2039800 <https://reviews.llvm.org/D79963#2039800>, @echristo wrote:

> The first patch seemed fine and pretty useful. I'm not certain that this is a particularly fun idea as far as having to redo all comments etc.


This patch addresses all of the cases where a `CHECK` prefix is used in a comment (but without a trailing colon), so aside from new tests, we won't need to rewrite any more comments to use this `COM:` prefix (or however it ends up being spelled).

>   Can you elaborate more on how much you've seen this happen etc?

See D77352 <https://reviews.llvm.org/D77352> and D77354 <https://reviews.llvm.org/D77354> (and several other follow-up patches) should make it clear the problem is quite pervasive, and ongoing.

- Almost all of the ones in D77352 <https://reviews.llvm.org/D77352> were benign.
- All of the ones in D77354 <https://reviews.llvm.org/D77354> were legit test case bugs. These are cases where the test hadn't been updated, was broken when the colon gets added, but the underlying codegen was more or less good.
- That said, I haven't found any that pointed at real codegen bugs... yet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79963/new/

https://reviews.llvm.org/D79963