[PATCH] D80048: [lld-macho] Support X86_64_RELOC_UNSIGNED

Fri May 15 17:24:55 PDT 2020

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

ld64 emits an entry in the rebase table so that the relocation can be adjusted for whatever the final load address ends up being. (I'm assuming it does this for all non-pcrel relocations.) Certainly not something we need to support in this diff, but we should add a TODO.

LGTM.

================
Comment at: lld/test/MachO/x86-64-reloc-unsigned.s:6
+# CHECK: Contents of section foo:
+# CHECK:  2000 08200000 00000000
+# CHECK: Contents of section bar:
----------------
Ah, it's annoying that endianness means we can't do the usual nice arithmetic checks here :/

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80048/new/

https://reviews.llvm.org/D80048