[PATCH] D79931: [mlir][spirv] Handle debuginfo for control flow ops.

Denis Khalikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 15 14:42:23 PDT 2020


denis13 marked an inline comment as done.
denis13 added inline comments.


================
Comment at: mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp:395
+  /// OpLine in the block must be before its merge instruction".
+  bool lastProcessedWasMergeInst = false;
+
----------------
antiagainst wrote:
> Super nit: can this be placed after the `emitDebugInfo` field? It's logically a field necessitated by `emitDebugInfo` so appearing after it would be nice. :)
Sure, thanks for review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79931/new/

https://reviews.llvm.org/D79931





More information about the llvm-commits mailing list