[PATCH] D80035: [MLIR] LinalgToStandard: use LINK_LIBS rather than target_link_libraries.

Stephen Neuendorffer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 15 14:42:17 PDT 2020


stephenneuendorffer created this revision.
Herald added subscribers: llvm-commits, jurahul, Kayjukh, frgossen, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini, mgorny.
Herald added a project: LLVM.
stephenneuendorffer added a reviewer: nicolasvasilache.

Also, missing MLIRTransforms as a dependency.  This breaks BUILD_SHARED_LIBS=on


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80035

Files:
  mlir/lib/Conversion/LinalgToStandard/CMakeLists.txt


Index: mlir/lib/Conversion/LinalgToStandard/CMakeLists.txt
===================================================================
--- mlir/lib/Conversion/LinalgToStandard/CMakeLists.txt
+++ mlir/lib/Conversion/LinalgToStandard/CMakeLists.txt
@@ -6,15 +6,14 @@
 
   DEPENDS
   MLIRConversionPassIncGen
-)
 
-target_link_libraries(MLIRLinalgToStandard
-  PUBLIC
+  LINK_LIBS PUBLIC
   MLIREDSC
   MLIRIR
   MLIRLinalgOps
   MLIRPass
   MLIRSCF
+  MLIRTransforms
   LLVMCore
   LLVMSupport
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80035.264342.patch
Type: text/x-patch
Size: 489 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200515/82f9d056/attachment.bin>


More information about the llvm-commits mailing list