[PATCH] D79798: [flang] Constraint checks C751 to C760

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added a comment.

I've submitted another update.



================
Comment at: flang/lib/Semantics/resolve-names.cpp:3677
+      CHECK(!attrs_);
+      attrs_ = std::make_optional<Attrs>();
+      Symbol *typeParam{MakeTypeSymbol(
----------------
tskeith wrote:
> You can use `BeginAttrs` here instead, and `EndAttrs` below.
Thanks, Tim.  Will do.


================
Comment at: flang/lib/Semantics/type.cpp:154
       } else {
-        messages.Say(name_,
-            "Type parameter '%s' lacks a value and has no default"_err_en_US,
-            name);
+        if (!symbol.test(Symbol::Flag::Error)) {
+          messages.Say(name_,
----------------
tskeith wrote:
> Could be `else if`
I will make it so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79798/new/

https://reviews.llvm.org/D79798