[PATCH] D77708: [lit] Improve naming of test result categories

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 15 12:31:30 PDT 2020


yln added a comment.

In D77708#2038628 <https://reviews.llvm.org/D77708#2038628>, @ldionne wrote:

> Are we moving forward with some version of this patch?


Yes, I would still like to if we can settle on a naming scheme.  I think that most of the preference here comes from familiarity/what sounds best, which of course is a bit subjective.

I renamed "Passing -> Passed" and "Failing -> Failed".  All category headers (the header printed before the list of tests in that group) are now adjective + "Test".  For summary counts we use just the adjective describing the category. Currently, @rnk still prefers to old names.  @rnk: is the updated scheme acceptable?

`ninja check-all` show no failing tests for me due to this change.

After we settle on a final name, I will do a search for the changed string in the entire repository.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77708/new/

https://reviews.llvm.org/D77708





More information about the llvm-commits mailing list