[PATCH] D80000: [MSSA] Doc: Clobbers, more info on Defs / Def chain

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea accepted this revision.
asbirlea marked an inline comment as done.
asbirlea added a comment.
This revision is now accepted and ready to land.

Thank you for the documentation improvements, much appreciated!
Looks good with a few nits inline.



================
Comment at: llvm/docs/MemorySSA.rst:25
 It can also be thought of as a way to cheaply give versions to the complete
-state of heap memory, and associate memory operations with those versions.
+state of memory, and associate memory operations with those versions.
 
----------------
baziotis wrote:
> A lot of times, the combo "heap memory" is used instead of just "memory". It doesn't seem to me that `MSSA` is heap-specific,
> do I miss something?
It is not heap-specific.


================
Comment at: llvm/docs/MemorySSA.rst:101
+If a ``MemoryAccess`` is a *clobber* of another, it means that these two
+``MemoryAccess``\ es access the same memory. For example, ``x = MemoryDef(y)``
+means that ``x`` potentially modifies memory that ``y`` modifies/constrains
----------------
s/access/may access


================
Comment at: llvm/docs/MemorySSA.rst:109
+(as an example, think that if ``x = MemoryDef(...)``
+and ``MemoryUse(x)`` are in the same loop, the use can't be hoisted outside).
+
----------------
s/the use can't be hoisted outside/the use can't be hoisted outside alone.

(It's possible they can be hoisted together; promotion to scalars does this.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80000/new/

https://reviews.llvm.org/D80000