[PATCH] D79545: [VE] Implements minimum MC layer for VE (3/4)

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/unittests/Object/ELFObjectFileTest.cpp:46
+  };
+  // A very simple ELF object file which contains empty data
+  auto ExpectedFile = create<ELF64LE>(Data);
----------------
kaz7 wrote:
> jhenderson wrote:
> > Nit: empty data -> no data
> > 
> > Also add the missing trailing full stop.
> Thanks for the correction.  I'm not sure about "trailing full stop" since I've never tried to generate ELF data previously.  I guess you are saying that above blob is not completed and need some trailing data.   I appreciate if you advise me with some concrete examples or references.
If you look carefully in the Phabricator UI, I've only selected the comment line, because I'm referring to the comment with the "missing trailing full stop". In other words, the comment should be:

"A very simple ELF object file which contains no data."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79545/new/

https://reviews.llvm.org/D79545