[PATCH] D79964: Update 'git push' command in GettingStarted guide

Diego Caballero via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 14 23:22:36 PDT 2020


dcaballe marked an inline comment as done.
dcaballe added inline comments.


================
Comment at: llvm/docs/Phabricator.rst:218
   ninja check-$whatever # Rerun the appropriate tests if needed.
-  git push
+  git push origin arcpatch-D<Revision>:master
 
----------------
echristo wrote:
> mehdi_amini wrote:
> > The generic way of pushing would rather be I believe:  `git push origin HEAD:master` what about using this instead? It is closer to ensuring you're pushing what you just tested (we should like tell folks to check that their local state is clean as well)
> > 
> > (note that origin is read-only locally for me, but I assume that for such doc we can assume a "default" setup)
> +1
It sounds good! I'll give it a try in my next commit and change it. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79964/new/

https://reviews.llvm.org/D79964





More information about the llvm-commits mailing list