[llvm] e0c1554 - Revert "[GlobalISel][InlineAsm] Add early return for memory inputs that need to be indirectified"

[Nico Weber via llvm-commits]

Author: Nico Weber
Date: 2020-05-14T19:37:05-04:00
New Revision: e0c155427408814ceff22d16352331006eb81b6b

URL: https://github.com/llvm/llvm-project/commit/e0c155427408814ceff22d16352331006eb81b6b
DIFF: https://github.com/llvm/llvm-project/commit/e0c155427408814ceff22d16352331006eb81b6b.diff

LOG: Revert "[GlobalISel][InlineAsm] Add early return for memory inputs that need to be indirectified"

This reverts commit 887dfeec53ad5e564e9990c433e5b53f2e651dbf.
It broke irtranslator-inline-asm.ll on many bots, e.g.
http://lab.llvm.org:8011/builders/lld-x86_64-freebsd/builds/38606/steps/test-check-all/logs/FAIL%3A%20LLVM%3A%3Airtranslator-inline-asm.ll

Added: 
    

Modified: 
    llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp
    llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp b/llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp
index 36d0aa3ad43f..e9ceaee83c39 100644
--- a/llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp
@@ -306,12 +306,6 @@ bool InlineAsmLowering::lowerInlineAsm(
     // Compute the constraint code and ConstraintType to use.
     computeConstraintToUse(TLI, OpInfo);
 
-    if (OpInfo.ConstraintType == TargetLowering::C_Memory &&
-        !OpInfo.isIndirect) {
-      LLVM_DEBUG(dbgs() << "Cannot indirectify memory input operands yet\n");
-      return false;
-    }
-
     // The selected constraint type might expose new sideeffects
     ExtraInfo.update(OpInfo);
   }

diff  --git a/llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll b/llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll
index 17e3a5ac8987..7e701db3494f 100644
--- a/llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll
+++ b/llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll
@@ -210,12 +210,3 @@ define i64 @strict_align_feature(i64* %p) #0 {
 }
 
 attributes #0 = { "target-features"="+strict-align" }
-
-; FALLBACK-WITH-REPORT-ERR: remark: <unknown>:0:0: unable to translate instruction: call
-; FALLBACK-WITH-REPORT-ERR: warning: Instruction selection used fallback path for direct_mem
-; FALLBACK-WITH-REPORT-OUT-LABEL: direct_mem
-define void @direct_mem(i32 %x, i32 %y) {
-entry:
-  tail call void asm sideeffect "", "imr,imr,~{memory}"(i32 %x, i32 %y)
-  ret void
-}