[PATCH] D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 14 15:15:03 PDT 2020


jdenny accepted this revision.
jdenny added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wuzish.

This looks like a move in the right direction to me, but I'm biased.  Hopefully others will chime in, especially individual test suite maintainers.

Here are some minor style suggestions, but feel free to outright ignore them if I'm the only one who cares:

1. Sometimes you add `COM:` only to lines your diagnostic might catch and not to other lines in the same comment block.  I'd prefer to see it on every line in a comment block.

2. Where `;;` was used to differentiate true comments from FileCheck check directives, you now have `;; COM:`.  I think `; COM:` is sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79963/new/

https://reviews.llvm.org/D79963





More information about the llvm-commits mailing list